-
Notifications
You must be signed in to change notification settings - Fork 46
Set up a GitHub Actions workflow #5
Set up a GitHub Actions workflow #5
Conversation
d0c2e6b
to
3031643
Compare
cf2c092
to
8b699c1
Compare
e48f66c
to
b8a918d
Compare
@phenaproxima this is done except for one thing that I don't know whether it's on the application side or the CI config side:
I've identified the database file created by creating the project ( |
b8a918d
to
99cb430
Compare
@phenaproxima I rebased onto
I can reproduce it locally, so it seems like it's an actual issue in the application. |
Yeah...we get that when the upstream patch changes but our patches.lock.json doesn't adjust. See what happens if you remove and gitignore patches.lock.json...? |
That doesn't seem to make any difference, @phenaproxima. |
a1d8612
to
2258021
Compare
The |
b828b07
to
5b05331
Compare
@phenaproxima I'm still getting the same error trying to load the site after it's installed:
Unfortunately, I'm having an unrelated problem with the build on this PR, but you can see the problem on the Any ideas while I work on the PR build problem? |
So about that SQLite error -- a quick search reveals https://stackoverflow.com/questions/3319112/sqlite-error-attempt-to-write-a-readonly-database-during-insert:
|
I've created a way around this, I think. (It's in First, let's use MySQL on CI, instead of SQLite, since it seems to be problem-prone. Pretty sure you can easily do that with GitHub Actions' Docker integration. What you'll need to do (pseudocode):
(This way, you can also remove the Drush requires To me, this is absolutely good enough. |
c4c80f8
to
bc1fb8b
Compare
bc1fb8b
to
e9b93e8
Compare
@phenaproxima we have a working PR now. It doesn't do everything the way we (you) want, but it's fully functional, and it catches the main issues we tend to encounter. I propose you merge it as-is so we start getting the benefit, and we can iterate on it as we choose. |
Yeah, I agree. Let's just merge it and sally forth bravely! |
Welp, it's failing: https://github.com/phenaproxima/drupal-suite/actions/runs/8851596378. Can you fix? 🙏 |
composer create-project
, not justcomposer install
)main
andwip
main
anddevelop
web
directory should be served by ApacheNotes
I assume that Apache is multi-threaded by default, but I haven't confirmed it. I don't know, for example, if it has to have the MPM worker specifically enabled. Unless you know the answer, I'll check on it (or it will become evident as soon as you try to do something in the build that requires it).This will be deferred to a follow-up, depending on whether it turns out to actually be an issue.